Hero6
It is currently Fri, 27 Jan 2023 19:00

All times are UTC - 8 hours


Post new topic Reply to topic  [ 2 posts ] 
Author Message
 Post subject: WTF - What The Function?
PostPosted: Wed, 09 Apr 2014 18:15 
Offline
Site Admin
User avatar

Joined: Wed, 18 Dec 2013 09:56
Posts: 101
After some tinkering last week, I've decided that it's impractical for me to move forward without renaming some functions. Even with the existing comments, it's extraordinarily difficult to code while having to remember that I need inventory_item62a instead of inventory_item63a. I'll be spending some time going through the scripts and renaming these functions.

However, while I'm on the topic of updating code. I really think we should transition the existing "DisplayMessage()" calls to at least include a comment explaining what the message is. I'm hesitant to use the "character.say()" call, it doesn't always look great. "Display()" would probably be a better option; otherwise, let's just add some comments.

While we're on the topic of comments, anyone who wants to add functionality comments to anything in the code will be my personal hero.

I've started compiling these development requirements. I'll place them in a changes spreadsheet... a delta matrix if you will :lol: (No offense intended delta, just couldn't resist the pun)

_________________
Robert

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
"What good is knowledge and wisdom if you can't use it?" - Erasmus


Top
 Profile  
 
PostPosted: Sun, 10 Aug 2014 03:19 
Offline
Casual Adventurer

Joined: Sat, 11 Jan 2014 15:20
Posts: 9
only just saw this post. very funny.

Sadly the badly named functions like inventory_item62a inherit from the old AGS 2.x where those functions were automatically generated and you couldn't change them. When this project started, AGS 3 didn't exist and some questionable practices had to be nurtured.

This is where the badly needed code refactor gets painful.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 2 posts ] 

All times are UTC - 8 hours

Who is online

Users browsing this forum: No registered users and 2 guests

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum
Search for:
Jump to:  

cron
Powered by phpBB® Forum Software © phpBB Group